-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DLC-BTC. Remove filtering from vault fetching logic, add network support #3389
Conversation
🦋 Changeset detectedLatest commit: 544c4a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I would suggest to ignore the ea-framework dependency check until we figure out what to do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes: contract as input param & related rework, typos
LGTM overall
packages/sources/dlc-btc-por/src/transport/proof-of-reserves.ts
Outdated
Show resolved
Hide resolved
279da2f
to
7fb4e5f
Compare
packages/sources/dlc-btc-por/src/transport/proof-of-reserves.ts
Outdated
Show resolved
Hide resolved
You can simply bump this one and the error will go away |
7fb4e5f
to
b35b4bb
Compare
Closes DF-20315
Description
Fixed BTC vault fetching logic. Previously we filtered out placeholder values, but DLC.LINK team now recommends to fetch all the vault and skip the filtering.
Additionally added support for different networks. Currently the EA was deployed to Aribtirum and to deploy to a new chain, a new instance is needed as the config options supported one chain. PR includes changes so that different chains and RPCs can be provided.
Changes
Steps to Test
yarn test packages/sources/dlc-btc-por/
Quality Assurance
infra-k8s
configuration file.adapter-secrets
configuration file or update the soak testing blacklist.test-payload.json
file with relevant requests.feature/x
,chore/x
,release/x
,hotfix/x
,fix/x
) or is created from Jira.