Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLC-BTC. Remove filtering from vault fetching logic, add network support #3389

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

karen-stepanyan
Copy link
Contributor

@karen-stepanyan karen-stepanyan commented Aug 14, 2024

Closes DF-20315

Description

Fixed BTC vault fetching logic. Previously we filtered out placeholder values, but DLC.LINK team now recommends to fetch all the vault and skip the filtering.
Additionally added support for different networks. Currently the EA was deployed to Aribtirum and to deploy to a new chain, a new instance is needed as the config options supported one chain. PR includes changes so that different chains and RPCs can be provided.

Changes

  • Removed the filter function from transport when fetching vault info
  • Added support for new chains
  • Replaced DLC_CONTRACT env variable with 'dlcContract' input parameter.
  • Replaced RPC_URL, CHAIN_ID env variables with network-specific env variables ( {NETWORK}_RPC_URL, {NETWORK}_CHAIN_ID ).
  • Added the EA to readme-generator blacklist as several config options are added to readme manually that are not part of config.ts

Steps to Test

yarn test packages/sources/dlc-btc-por/

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: 544c4a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/dlc-btc-por-adapter Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@karen-stepanyan
Copy link
Contributor Author

I would suggest to ignore the ea-framework dependency check until we figure out what to do

@karen-stepanyan karen-stepanyan requested a review from a team August 14, 2024 16:34
Copy link
Contributor

@mmcallister-cll mmcallister-cll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes: contract as input param & related rework, typos
LGTM overall

mxiao-cll
mxiao-cll previously approved these changes Aug 19, 2024
@mxiao-cll
Copy link
Contributor

I would suggest to ignore the ea-framework dependency check until we figure out what to do

You can simply bump this one and the error will go away

@karen-stepanyan karen-stepanyan merged commit 26a9a02 into main Aug 20, 2024
7 of 8 checks passed
@karen-stepanyan karen-stepanyan deleted the feature/DF-20315 branch August 20, 2024 14:07
@github-actions github-actions bot mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants