Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

por-indexer: Override MAX_PAYLOAD_SIZE_LIMIT to default to 5MB #3339

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

alecgard
Copy link
Contributor

@alecgard alecgard commented Jul 1, 2024

  • Default MAX_PAYLOAD_SIZE_LIMIT to 5MB for por-indexer.
    • We have seen cases where PoR address lists exceed 5MB, and so cause issues as requests get blocked by fastify and so are not processed by the EA.
    • This PR increases the default from 1MB to 5MB, to increase the headroom before we experience these issues.
  • https://smartcontract-it.atlassian.net/browse/DF-20251

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

Copy link

changeset-bot bot commented Jul 1, 2024

🦋 Changeset detected

Latest commit: a39ed1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@chainlink/por-indexer-adapter Minor
@chainlink/proof-of-reserves-adapter Patch
@chainlink/renvm-address-set-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alecgard alecgard marked this pull request as ready for review July 1, 2024 13:26
@alecgard alecgard requested a review from a team July 1, 2024 13:26
@alecgard alecgard merged commit e4bd1d9 into main Jul 1, 2024
8 checks passed
@alecgard alecgard deleted the feat/por-indexer-max-payload-size-override branch July 1, 2024 13:29
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants