Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env var default override to eth-beacon #3178

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

amit-momin
Copy link
Contributor

@amit-momin amit-momin commented Feb 8, 2024

Closes DF-19482

Description

Recent job using eth-beacon had a payload exceed the default limit (1MB) set in the Fastify server. Added an env var default override to set the payload limit to 5MB to allow for the growing request size the adapter is used for.

Changes

  • Set MAX_PAYLOAD_SIZE_LIMIT to 5000000 in envDefaultOverrides

Steps to Test

  1. yarn test packages/sources/eth-beacon/test

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

Copy link

changeset-bot bot commented Feb 8, 2024

🦋 Changeset detected

Latest commit: a729ca4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@chainlink/eth-beacon-adapter Patch
@chainlink/proof-of-reserves-adapter Patch
@chainlink/renvm-address-set-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@amit-momin amit-momin merged commit eeff213 into main Feb 8, 2024
7 of 8 checks passed
@amit-momin amit-momin deleted the feature/eth-beacon-env-var-override branch February 8, 2024 17:38
@github-actions github-actions bot mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants