Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FraxEthDualOracle contract address and ABI. #3142

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

alecgard
Copy link
Contributor

@alecgard alecgard commented Jan 11, 2024

Closes DF-19440

Description

  • Update frxeth-exchange-rate EA to reference the updated FraxEthDualOracle contract.

Changes

  • Default to new contract address
  • Update ABI
  • Update response parameter names based on ABI update

Steps to Test

curl --location 'localhost:8080' \
--header 'Content-Type: application/json' \
--data '{
	"id": "1",
	"data": {
		"priceType": "low",
		"endpoint": "crypto"
  }
}'

{
    "data": {
        "result": "996957764310337236"
    },
    "result": "996957764310337236",
    "timestamps": {
        "providerDataRequestedUnixMs": 1704988678103,
        "providerDataReceivedUnixMs": 1704988679551
    },
    "statusCode": 200,
    "meta": {
        "adapterName": "FRXETH-EXCHANGE-RATE",
        "metrics": {
            "feedId": "{\"priceType\":\"low\"}"
        }
    }
}

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

Copy link

changeset-bot bot commented Jan 11, 2024

🦋 Changeset detected

Latest commit: 8a092fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/frxeth-exchange-rate-adapter Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alecgard alecgard marked this pull request as ready for review January 11, 2024 16:06
@alecgard alecgard requested a review from a team January 11, 2024 16:07
@alecgard alecgard merged commit 0734e09 into main Jan 11, 2024
8 checks passed
@alecgard alecgard deleted the feat/frx-eth-contract-update branch January 11, 2024 17:20
@github-actions github-actions bot mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants