Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove openzeppelin dependency #1397

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

boxhock
Copy link
Contributor

@boxhock boxhock commented Jan 6, 2022

Description

There is a security vulnerability alert due to the version of @openzeppelin/contracts we have imported in the APY Finance adapter. However, it seems like we don't actually use this dependency.

Instead of updating the dependency in #1307, we can just remove it.

......

Changes

  • Remove @openzeppelin/contracts dependency from package.json

Steps to Test

  1. Run the adapter?

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant <ADAPTER_PACKAGE>/schemas/env.json and <ADAPTER_PACKAGE>/README.md
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Clubhouse/Shortcut
  • This is related to a maximum of one Clubhouse/Shortcut story or GitHub issue
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types)

@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2022

⚠️ No Changeset found

Latest commit: 5df2c9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@boxhock boxhock temporarily deployed to QA January 6, 2022 14:03 Inactive
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #1397 (5df2c9c) into develop (cf81f1b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1397   +/-   ##
========================================
  Coverage    79.67%   79.67%           
========================================
  Files          744      744           
  Lines        30360    30360           
  Branches      2273     2273           
========================================
  Hits         24190    24190           
  Misses        6170     6170           
Flag Coverage Δ
integration 88.27% <ø> (ø)
unit 63.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@austinborn
Copy link
Contributor

Can you check why that build step is failing?

@boxhock
Copy link
Contributor Author

boxhock commented Jan 6, 2022

@austinborn seems to be happening randomly because of rate-limiting or something. Will re-run it

@boxhock boxhock merged commit 7b860dd into develop Jan 6, 2022
@boxhock boxhock deleted the chore/remove-openzeppelin-dependency branch January 6, 2022 19:30
@boxhock boxhock temporarily deployed to QA January 6, 2022 19:30 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants