-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ccip/1.5.1 remix #2205
Merged
Merged
Ccip/1.5.1 remix #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Crystal Gomes <thedriftofwords@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking feedback:
Prerequisites
- Web browser setup: Add link or reminder to check supported networks page
- Native gas tokens: Add link to billing page (for users who need guidance on how much gas tokens are enough
Blockchain setup
- UI nit: The "<>" between the dropdown fields is clickable which might lead users to expect they can swap the values of the fields by clicking that
src/components/CCIP/TutorialBlockchainSelector/AdminSetupStep.tsx
Outdated
Show resolved
Hide resolved
src/content/ccip/tutorials/cross-chain-tokens/register-from-eoa-remix.mdx
Outdated
Show resolved
Hide resolved
thedriftofwords
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent 🚀
Co-authored-by: Crystal Gomes <thedriftofwords@users.noreply.github.com>
…a-remix.mdx Co-authored-by: Crystal Gomes <thedriftofwords@users.noreply.github.com>
Co-authored-by: Crystal Gomes <thedriftofwords@users.noreply.github.com>
Co-authored-by: Crystal Gomes <thedriftofwords@users.noreply.github.com>
Co-authored-by: Crystal Gomes <thedriftofwords@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.