-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chainlink local #2012
Chainlink local #2012
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: Adding my first round of editorial review as comments to share my thought process; I'll follow up by addressing most of my own comments directly as commits, leaving open those that I have a question about.
src/content/chainlink-local/build/ccip/remix/local-simulator.mdx
Outdated
Show resolved
Hide resolved
date: Last Modified | ||
title: "Test CCIP Locally" | ||
--- | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General editing checks
- Sentence case on titles and section titles
- Decide on the best definition for CL Local and use it consistently in page overviews and conceptual pages - is it a library? a set of installable packages? a set of tools and libraries?
- Replace diagram drafts with updated ones from design team when available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/content/chainlink-local/build/ccip/foundry/local-simulator-fork.mdx
Outdated
Show resolved
Hide resolved
src/content/chainlink-local/build/ccip/foundry/local-simulator-fork.mdx
Outdated
Show resolved
Hide resolved
src/content/chainlink-local/build/ccip/foundry/local-simulator-fork.mdx
Outdated
Show resolved
Hide resolved
Some of my own comments above left open intentionally; these items need discussion and a follow-up PR, but aren't blockers to initially publishing these docs. |
* chainlink-local api ref * chainlink-local api ref * First edit pass: intro page and minor formatting stuff in API pages * Baseline architecture page + main page minor fix * Edit 1 on architecture page * Revisions round 2 * Link fix * Baseline local simulator guide * First edit pass on local simulator guide * Local simulator guide: edit round 2 plus images * Add to sidebar; formatting fix * Baseline simulator fork content plus attempted boilerplate to use PageTabs * chainlink local * add index * add index * fix formatting * fix formatting * fix formatting * fix links * fix links * fix links * hardhat guides * index * fix links * install instructions * remix * remix * remix * remix * remix * remix * contributing * video * architecture * nit * refer in CCIP * nit * edit: architecture * edit: ccip guides index pages * edit: ccip hardhat guides * edit: sidebar and ccip remix guide * edit: data feeds api pages, main intro page * edit: ccip foundry guides * edit: miscellaneous nits * nit * pin @chainlink/local version --------- Co-authored-by: Crystal Gomes <thedriftofwords@users.noreply.github.com>
https://documentation-git-ccip-local-chainlinklabs.vercel.app/chainlink-local