Update DataConsumerWithSequencerCheck.sol #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviggiano
requested review from
dwightjl,
aelmanaa,
thedriftofwords and
khadni
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for opening this PR. I'm confirming how best to handle situations where |
|
My understanding is that correctly handling |
thedriftofwords
previously requested changes
Jul 29, 2024
|
Still getting confirmation on some changes here. |
Co-authored-by: Crystal Gomes <thedriftofwords@users.noreply.github.com>
dwightjl
added
Chainlink Data Feeds
and removed
blocked
dwightjl
approved these changes
Aug 8, 2024
thedriftofwords
added a commit
to thedriftofwords/documentation
that referenced
this pull request
Aug 14, 2024
* Update DataConsumerWithSequencerCheck.sol * Add optional code for invalid L2 feed round * Clarify how to handle startedAt 0 * Update src/content/data-feeds/l2-sequencer-feeds.mdx Co-authored-by: Crystal Gomes <thedriftofwords@users.noreply.github.com> * Restore example and update startedAt description * Edit --------- Co-authored-by: Dwight Lyle <dwightjl@gmail.com> Co-authored-by: Crystal Gomes <thedriftofwords@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.Any change needs to be discussed before proceeding.
Closing issues
Closes #1994
Description
Updates code sample to match documentation
Changes
PriceFeed.getPrice()contract. code-423n4/2024-06-size-findings#209