Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove codecgen from .tool-versions #8729

Merged
merged 9 commits into from
Mar 20, 2023
Merged

remove codecgen from .tool-versions #8729

merged 9 commits into from
Mar 20, 2023

Conversation

krehermann
Copy link
Contributor

No description provided.

@krehermann krehermann requested a review from a team as a code owner March 16, 2023 18:50
@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@krehermann krehermann force-pushed the chore/fix-codec-tools branch from 7ac6d53 to 6a0d355 Compare March 16, 2023 18:51
@krehermann krehermann requested a review from eutopian March 16, 2023 18:52
eutopian
eutopian previously approved these changes Mar 16, 2023
View reviewed changes
jmank88
jmank88 previously approved these changes Mar 16, 2023
View reviewed changes
@krehermann krehermann dismissed stale reviews from jmank88 and eutopian via ee85025 March 16, 2023 23:10
@krehermann krehermann force-pushed the chore/fix-codec-tools branch from 72270fb to ee85025 Compare March 16, 2023 23:10
krehermann
krehermann commented Mar 16, 2023
View reviewed changes
Copy link
Contributor Author

@krehermann krehermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to push again to get CI out of a stuck loop failing on an unrelated test

@krehermann krehermann requested review from eutopian and jmank88 March 16, 2023 23:11
jmank88
jmank88 previously approved these changes Mar 16, 2023
View reviewed changes
eutopian
eutopian previously approved these changes Mar 16, 2023
View reviewed changes
@krehermann krehermann dismissed stale reviews from eutopian and jmank88 via b6a9509 March 17, 2023 13:21
@krehermann krehermann force-pushed the chore/fix-codec-tools branch from b6a9509 to 746237b Compare March 17, 2023 13:29
prashantkumar1982
prashantkumar1982 reviewed Mar 17, 2023
View reviewed changes
.tool-versions
@@ -6,4 +6,3 @@ helm 3.10.3
zig 0.10.1
golangci-lint 1.51.2
shellspec 0.28.1
codecgen 1.2.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why was this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added it mistakenly because it seemed like all our tools were listed here. i'm not sure what this file is intended to do

Copy link
Contributor

@eutopian eutopian Mar 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh... maybe we should add this to the readme somewhere; .tool-versions is the file for asdf managed dev tools and runtimes https://asdf-vm.com/ to help ensure version consistency, but it also only works for supported packages

prashantkumar1982
prashantkumar1982 previously approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@prashantkumar1982 prashantkumar1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that since @jkongie approved and merged the underlying wsrpc changes, this should be good to go.

@krehermann krehermann requested a review from jmank88 March 17, 2023 19:18
@krehermann krehermann requested a review from eutopian March 17, 2023 19:32
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@eutopian eutopian merged commit 3435ac6 into develop Mar 20, 2023
@eutopian eutopian deleted the chore/fix-codec-tools branch March 20, 2023 16:10
smickovskid pushed a commit that referenced this pull request Mar 23, 2023
@krehermann @smickovskid
remove codecgen from .tool-versions (#8729)
3df4e04 
* Remove codecgen from .tool-versions
@chainchad chainchad mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eutopian eutopian eutopian approved these changes

@jmank88 jmank88 jmank88 approved these changes

@prashantkumar1982 prashantkumar1982 prashantkumar1982 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krehermann @jmank88 @eutopian @prashantkumar1982