Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/cmd/local_client: replace DATABASE_URL references #8708

Merged
merged 2 commits into from
Mar 16, 2023
Merged

core/cmd/local_client: replace DATABASE_URL references #8708

merged 2 commits into from
Mar 16, 2023

Conversation

cfal
Copy link
Contributor

@cfal cfal commented Mar 15, 2023

since setting DATABASE_URL doesn't work anymore for make testdb/db preparetest

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

jmank88
jmank88 reviewed Mar 15, 2023
View reviewed changes
core/cmd/local_client.go Outdated Show resolved Hide resolved
@cfal cfal requested a review from jmank88 March 15, 2023 15:45
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@archseer archseer merged commit 06e7f48 into develop Mar 16, 2023
@archseer archseer deleted the db-env-msgs branch March 16, 2023 02:22
@chainchad chainchad mentioned this pull request Mar 16, 2023
Merged
@chainchad chainchad mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@jmank88 jmank88 jmank88 approved these changes

@jkongie jkongie Awaiting requested review from jkongie

@samsondav samsondav Awaiting requested review from samsondav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cfal @jmank88 @prashantkumar1982 @archseer