Fixes new job proposals not storing the name when received (#8699) #8702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job proposals were not deserializing the TOML data correctly, leading the job proposal name to be set to null. This fixes the issue by correctly using a pointer to the target struct, so that the value can be returned.
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
SonarQube Quality Gate
|
jmank88
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Job proposals were not deserializing the TOML data correctly, leading the job proposal name to be set to null. This fixes the issue by correctly using a pointer to the target struct, so that the value can be returned.