Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove legacy config #8689

Merged
merged 2 commits into from
Mar 13, 2023
Merged

remove legacy config #8689

merged 2 commits into from
Mar 13, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Mar 13, 2023 •
edited
Loading

https://smartcontract-it.atlassian.net/browse/BCF-2134

  • core/cmd: remove keys eth update
  • core/chains: remove legacy config code

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@jmank88 jmank88 changed the title core/cmd: remove keys eth update remove legacy config Mar 13, 2023
@jmank88 jmank88 force-pushed the BCF-2134-cli-mutable-config branch 3 times, most recently from 80eb93b to c1eb896 Compare March 13, 2023 20:11
@jmank88 jmank88 requested a review from connorwstein as a code owner March 13, 2023 20:11
@jmank88 jmank88 force-pushed the BCF-2134-cli-mutable-config branch from c1eb896 to df6798e Compare March 13, 2023 20:12
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jmank88 jmank88 merged commit 1e0ab24 into develop Mar 13, 2023
@jmank88 jmank88 deleted the BCF-2134-cli-mutable-config branch March 13, 2023 20:48
@chainchad chainchad mentioned this pull request Mar 16, 2023
Merged
@chainchad chainchad mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsondav samsondav samsondav approved these changes

@jkongie jkongie Awaiting requested review from jkongie

@prashantkumar1982 prashantkumar1982 Awaiting requested review from prashantkumar1982

@connorwstein connorwstein Awaiting requested review from connorwstein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmank88 @samsondav