Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

None blocking telemetry #8684

Merged
merged 11 commits into from
Mar 15, 2023

Conversation

george-dorin
Copy link
Contributor

@george-dorin george-dorin commented Mar 13, 2023

Add config digest to exported telemtry fields
Make telemetry collection non-blocking
https://smartcontract-it.atlassian.net/browse/BCF-2037
https://smartcontract-it.atlassian.net/browse/BCF-2127

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@george-dorin george-dorin marked this pull request as ready for review March 14, 2023 15:00
@george-dorin george-dorin changed the title Add configDigest to telem Add configDigest to telem wrapper Mar 14, 2023
@george-dorin george-dorin changed the title Add configDigest to telem wrapper None blocking telemetry Mar 14, 2023
core/services/ocrcommon/telemetry_test.go Outdated Show resolved Hide resolved
core/services/ocrcommon/telemetry.go Show resolved Hide resolved
Change to wg.Add(1)
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 78.3% 78.3% Coverage on New Code (is less than 90%)

See analysis details on SonarQube

@george-dorin george-dorin merged commit e6c9e15 into develop Mar 15, 2023
@george-dorin george-dorin deleted the chore/BCF-2127_non_blocking_telemetry_extraction branch March 15, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants