allow pending job proposals to be revoked #8657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eutopian
force-pushed
the
FMS-48/revoke-jobs
branch
from
5f53dba to
77409e4
Compare
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
eutopian
force-pushed
the
FMS-48/revoke-jobs
branch
2 times, most recently
from
e204067 to
facb152
Compare
eutopian
force-pushed
the
FMS-48/revoke-jobs
branch
5 times, most recently
from
6cee084 to
b3d7eb2
Compare
eutopian
force-pushed
the
FMS-48/revoke-jobs
branch
from
b3d7eb2 to
71f163e
Compare
jmank88
approved these changes
Mar 13, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow FMS to send revoke job requests to the node operators. Before a job has been approved by a node operator, FMS can send a revoke request. The revoked job proposal will no longer be approvable, but it can be reproposed with a new pending job spec.