Fix not retrying the previous attempt when failing connectivity check #8651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
samsondav
previously approved these changes
Mar 8, 2023
prashantkumar1982
previously approved these changes
Mar 8, 2023
dimriou
dismissed stale reviews from prashantkumar1982 and samsondav
via
1c32184
dimriou
force-pushed
the
bci-941_fix_gas_bumping_retry
branch
from
a770a63 to
1c32184
Compare
dimriou
force-pushed
the
bci-941_fix_gas_bumping_retry
branch
from
1c32184 to
0336574
Compare
|
SonarQube Quality Gate
|
samsondav
approved these changes
Mar 9, 2023
prashantkumar1982
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug we had where we wouldn't retry the previous attempt if the gas bumping failed due to the connectivity checker.