-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TT-181 init test logger #8640
TT-181 init test logger #8640
Conversation
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
@@ -336,3 +339,15 @@ func EncodeOnChainExternalJobID(jobID uuid.UUID) [32]byte { | |||
copy(ji[:], strings.Replace(jobID.String(), "-", "", 4)) | |||
return ji | |||
} | |||
|
|||
// GetTestLogger instantiates a logger that takes into account the test context and the log level | |||
func GetTestLogger(t *testing.T) zerolog.Logger { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually think this might make more sense to add to the chainlink-env environment or config modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skudasov what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo we can just have logger.go
in each repo.
Added this to
actions