BCF-2117 More thorough block JSON testing #8637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a warmup for BCF-991 faster JSON unmarshal'ing - Adds tests for Transaction and TxType JSON un/marshal'ing - Adds the baseline benchmark The benchmark needs to marshal and unmarshal JSON in order to easily create various size input for the number of transactions. The roundtrip did not work because we had custom UnmarshalJSON logic, but nothing for Marshaling. Therefore, in order to write the benchmark efficiently, I had to implement some minimal JSON marshal'ing logic. This is tested as part of the new unit tests. Once this is merged, we can fix BCF-991 and be confidient about the change
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
reviewed
Mar 7, 2023
jmank88
reviewed
Mar 7, 2023
jmank88
reviewed
Mar 7, 2023
Co-authored-by: Jordan Krage <jmank88@gmail.com>
jmank88
previously approved these changes
Mar 7, 2023
jmank88
approved these changes
Mar 7, 2023
…e-changing-json-un-marshal
|
SonarQube Quality Gate
|
krehermann
deleted the
BCF-2117-Create-more-thorough-tests-before-changing-json-un-marshal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a warmup for BCF-991 faster JSON unmarshal'ing
The benchmark needs to marshal and unmarshal JSON in order to easily create various size input for the number of transactions. The roundtrip did not work because we had custom UnmarshalJSON logic, but nothing for Marshaling.
Therefore, in order to write the benchmark efficiently, I had to implement some minimal JSON marshal'ing logic.
This is tested as part of the new unit tests.
Once this is merged, we can fix BCF-991 and be confidient about the change