-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error buffer util #8620
Merged
Merged
Add error buffer util #8620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
krehermann
reviewed
Mar 3, 2023
krehermann
previously approved these changes
Mar 3, 2023
jmank88
previously approved these changes
Mar 3, 2023
essamhassan
force-pushed
the
util/add-error-buffer
branch
from
March 6, 2023 11:47
90a6fbb
to
68ac150
Compare
jmank88
reviewed
Mar 6, 2023
essamhassan
force-pushed
the
util/add-error-buffer
branch
from
March 6, 2023 17:24
bfe33f7
to
7f4e142
Compare
essamhassan
force-pushed
the
util/add-error-buffer
branch
from
March 6, 2023 17:31
7f4e142
to
cca49fc
Compare
krehermann
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This util makes use of the go1.20 error changes and expose a ring buffer interface for errors. This can be useful for tracking latest K crits on a service. Next steps is including this as part of startstoponce iface
Example Usage
Go errors @1.20