Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor tests to use testing.T aware logger #8618

Merged
merged 2 commits into from
Mar 3, 2023
Merged

refactor tests to use testing.T aware logger #8618

merged 2 commits into from
Mar 3, 2023

Conversation

gheorghestrimtu
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@gheorghestrimtu gheorghestrimtu marked this pull request as ready for review March 3, 2023 07:13
@gheorghestrimtu gheorghestrimtu requested review from a team as code owners March 3, 2023 07:13
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 10.9% 10.88% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@tateexon tateexon merged commit 5526378 into develop Mar 3, 2023
@tateexon tateexon deleted the TT-181-chainlink-core branch March 3, 2023 21:26
@chainchad chainchad mentioned this pull request Mar 16, 2023
Merged
@chainchad chainchad mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tateexon tateexon tateexon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gheorghestrimtu @tateexon