Don't Stop unstarted app in RebroadcastTransactions #8615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
previously approved these changes
Mar 3, 2023
jmank88
approved these changes
Mar 7, 2023
reductionista
approved these changes
Mar 14, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RebroadcastTransactionslocal command initializes an application, does not start it, and defers callingStopon the app. The command uses some of the app's dependencies (e.g. keystore, chains, db), but does not need the apps' long lived services. Calling Stop on an unstarted application will panic (see here). As far as I can tell this panic will be thrown at the end of every invocation of this command.This panic-if-not-started check was added much later after RebroadcastTransactions's calling Stop which itself was added about 3 years ago. It's possible that whatever reason the Stop was originally put in place is no longer relevant and this call site was missed when the started check was added.
This PR simply simply removes the Stop call which seems safe to do.