BCI-268: fix error logging bug #8611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustbleeds
requested review from
samsondav and
prashantkumar1982
as code owners
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
samsondav
approved these changes
Mar 2, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced logging an error when no error exists. Note that the the caller of
GetEthTxInProgressdidn't see an error because this gets transformed into a nil value.To fix this, we now just return nil directly and set
etx = nilinside of the callbackAlso passed in qopts to WithOpts. Doesn't matter for now since it's called without options but need to do anyways
For more info see original thread: https://chainlink-core.slack.com/archives/C03EZMT3XPX/p1677756433336309