BCI-268: fix distinct query #8606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustbleeds
requested review from
samsondav and
prashantkumar1982
as code owners
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
approved these changes
Mar 1, 2023
prashantkumar1982
approved these changes
Mar 2, 2023
|
SonarQube Quality Gate
|
chainchad
pushed a commit
that referenced
this pull request
Mar 6, 2023
Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com> (cherry picked from commit de3c326)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue in this thread https://chainlink-core.slack.com/archives/C0117GGJB6Y/p1677691496588749
Not sure why
TestORM_FindEthTxAttemptsRequiringResendtests pass but issue above appeared. It could be that in the thread Chris is using a different version of Postgres?Changes the SELECT DISTINCT columns to also match the ORDER BY columns by explicitly specifying the table that nonce belongs to