Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert must decode to function that does not panic #8591

Merged
merged 1 commit into from
Mar 1, 2023
Merged

convert must decode to function that does not panic #8591

merged 1 commit into from
Mar 1, 2023

Conversation

EasterTheBunny
Copy link
Contributor

No description provided.

@EasterTheBunny EasterTheBunny marked this pull request as ready for review February 28, 2023 18:23
@EasterTheBunny EasterTheBunny requested a review from a team as a code owner February 28, 2023 18:23
@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@EasterTheBunny EasterTheBunny force-pushed the AUTO-2208/remove-must-decode branch from e5cb811 to 711f4d7 Compare February 28, 2023 18:24
RyanRHall
RyanRHall previously approved these changes Feb 28, 2023
View reviewed changes
infiloop2
infiloop2 previously approved these changes Feb 28, 2023
View reviewed changes
@EasterTheBunny EasterTheBunny force-pushed the AUTO-2208/remove-must-decode branch from 711f4d7 to 8f89174 Compare March 1, 2023 14:53
@EasterTheBunny EasterTheBunny dismissed stale reviews from infiloop2 and RyanRHall via bfc453c March 1, 2023 15:10
@EasterTheBunny EasterTheBunny force-pushed the AUTO-2208/remove-must-decode branch from 8f89174 to bfc453c Compare March 1, 2023 15:10
@EasterTheBunny EasterTheBunny force-pushed the AUTO-2208/remove-must-decode branch from bfc453c to c429833 Compare March 1, 2023 15:11
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@EasterTheBunny EasterTheBunny merged commit 89260f6 into develop Mar 1, 2023
@EasterTheBunny EasterTheBunny deleted the AUTO-2208/remove-must-decode branch March 1, 2023 15:38
@chainchad chainchad mentioned this pull request Mar 16, 2023
Merged
@chainchad chainchad mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infiloop2 infiloop2 infiloop2 approved these changes

@RyanRHall RyanRHall RyanRHall left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EasterTheBunny @RyanRHall @infiloop2