Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/cmd: fix CL_CONFIG handling #8474

Merged
merged 2 commits into from
Feb 17, 2023
Merged

core/cmd: fix CL_CONFIG handling #8474

merged 2 commits into from
Feb 17, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Feb 17, 2023

No description provided.

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

chainchad
chainchad reviewed Feb 17, 2023
View reviewed changes
core/cmd/app.go Outdated Show resolved Hide resolved
@jmank88 @chainchad
Update core/cmd/app.go
047798a 
Co-authored-by: chainchad <96362174+chainchad@users.noreply.github.com>
@chainchad chainchad merged commit b781c74 into release/1.12.1 Feb 17, 2023
@chainchad chainchad deleted the fix-config-env-1.12.1 branch February 17, 2023 16:11
@jmank88 jmank88 mentioned this pull request Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chainchad chainchad chainchad left review comments

@krehermann krehermann krehermann approved these changes

@essamhassan essamhassan essamhassan approved these changes

@jkongie jkongie Awaiting requested review from jkongie jkongie is a code owner

@samsondav samsondav Awaiting requested review from samsondav samsondav is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmank88 @essamhassan @krehermann @chainchad