Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dynamic TOML #8421

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Support dynamic TOML #8421

merged 4 commits into from
Feb 13, 2023

Conversation

krehermann
Copy link
Contributor

BFC-1994

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

jmank88
jmank88 previously approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@jmank88 jmank88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM but we should probably update the doc on the subcommand, and maybe add a note to the changelog as well.

jmank88
jmank88 previously approved these changes Feb 10, 2023
View reviewed changes
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 75.0% Line Coverage on New Code (is less than 95%)
Failed condition 12 Lines to Cover on New Code (is greater than 5)

See analysis details on SonarQube

@krehermann krehermann merged commit ee9fd17 into develop Feb 13, 2023
@krehermann krehermann deleted the BFC-1994-toml-dynamic-fields branch February 13, 2023 17:23
chainchad pushed a commit that referenced this pull request Feb 16, 2023
@krehermann @chainchad
Support dynamic TOML (#8421)
fc427ec 
(cherry picked from commit ee9fd17)
smickovskid pushed a commit that referenced this pull request Mar 23, 2023
@krehermann @smickovskid
Support dynamic TOML (#8421)
94fa8c1 
(cherry picked from commit ee9fd17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@jkongie jkongie Awaiting requested review from jkongie

@samsondav samsondav Awaiting requested review from samsondav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krehermann @jmank88