Add waitForService to TS integration test #2472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanRHall
commented
Mar 11, 2020
| eth:clean Reset blockchain data to genesis state | ||
| cl:clean Reset chainlink database | ||
| eth:restart Reset blockchain data to genesis state | ||
| cl:restart Reset chainlink database | ||
|
|
There was a problem hiding this comment.
unrelated to this PR - fixes compose help output
HenryNguyen5
suggested changes
Mar 11, 2020
RyanRHall
force-pushed
the
add-waitForService-function-to-integration-test
branch
2 times, most recently
from
ce6a6ec to
11f8a0c
Compare
HenryNguyen5
suggested changes
Mar 12, 2020
|
Going to close this PR and merge these changes into the PR for the multi-node integration test, seeing as this race doesn't actually seem to be an issue right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes race condition in TS integration test by waiting for CL node before initiating test suit.
Waiting for #2476