Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/services: log ocr2 job type #16004

Merged
merged 1 commit into from
Jan 21, 2025
Merged

core/services: log ocr2 job type #16004

merged 1 commit into from
Jan 21, 2025

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Jan 21, 2025

Add job type to ocr2 logger name and remove unused logger from kVStore.

-logger=OCR2.ec912c2c-d933-4155-9325-daaf1168d5fa
+logger=OCR2.<job-type>.ec912c2c-d933-4155-9325-daaf1168d5fa

@jmank88 jmank88 requested review from a team as code owners January 21, 2025 13:17
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@jmank88 jmank88 requested a review from samsondav January 21, 2025 13:19
@jmank88 jmank88 enabled auto-merge January 21, 2025 13:19
@cl-sonarqube-production
Copy link

@jmank88 jmank88 added this pull request to the merge queue Jan 21, 2025
auto-merge was automatically disabled January 21, 2025 13:46

Pull Request is not mergeable

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@jmank88 jmank88 added this pull request to the merge queue Jan 21, 2025
Merged via the queue into develop with commit f7eef5c Jan 21, 2025
168 of 171 checks passed
@jmank88 jmank88 deleted the ocr2-logs branch January 21, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants