destexecdata decoder support + refactor #15978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
huangzhen1997
requested review from
cedric-cordenier,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
prashantkumar1982
previously approved these changes
Jan 24, 2025
prashantkumar1982
previously approved these changes
Jan 27, 2025
winder
reviewed
Jan 27, 2025
go.mod
Outdated
| @@ -78,7 +78,7 @@ require ( | |||
| github.com/shopspring/decimal v1.4.0 | |||
| github.com/smartcontractkit/chain-selectors v1.0.36 | |||
| github.com/smartcontractkit/chainlink-automation v0.8.1 | |||
| github.com/smartcontractkit/chainlink-ccip v0.0.0-20250123161904-c40aa8ca45b2 | |||
| github.com/smartcontractkit/chainlink-ccip v0.0.0-20250127153115-8110edbdc289 | |||
There was a problem hiding this comment.
There's no need to update this dependency.
There was a problem hiding this comment.
Will be updated once we merge the smartcontractkit/chainlink-ccip#472
winder
requested changes
Jan 27, 2025
winder
reviewed
Jan 27, 2025
| return ExtraDataCodec{} | ||
| } | ||
|
|
||
| func (c ExtraDataCodec) DecodeExtraArgs(extraArgs cciptypes.Bytes, sourceChainSelector cciptypes.ChainSelector) (map[string]any, error) { |
There was a problem hiding this comment.
Looks like you're missing DecodeExtraData, I thought you were just adding DecodeTokenAmountDestExecData. You'll need to add the old value and deprecate/remove it in a future PR.
There was a problem hiding this comment.
I was renaming it from DecodeExtraData to DecodeExtraArgs since it wasn't accurate.
|
winder
approved these changes
Jan 28, 2025
prashantkumar1982
approved these changes
Jan 28, 2025
prashantkumar1982
deleted the
NONEVM-1163/update-plugin-factory-with-destexecdata-decoder
branch
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 2 for https://smartcontract-it.atlassian.net/browse/NONEVM-1163. This PR implements a new function added for plugin oracle creator extradata codec based on smartcontractkit/chainlink-ccip#472. This PR is just an noop, the actual implementation will be submitted with a different PR and gets merged into
solana-offchain-pluginbranch, where we need to process the bytes base on the source chain and reassign the bytes to message.