-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP Load Test utilizing crib setup #15954
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
"github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/router" | ||
) | ||
|
||
type SeqNumRange struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use ccipocr3.SeqNumRange
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to use the atomic
library here to capture race conditions, but i'm open to modifying it if you think that's unnecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial Review
WSRPCs []CribRPCs // websocket rpcs to connect to the chain | ||
HTTPRPCs []CribRPCs // http rpcs to connect to the chain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's create new entries instead of modifying this. We might simply want to connect to testnet chains with this. Internal and external would be confusing in that case
} | ||
|
||
sink := make(chan *offramp.OffRampCommitReportAccepted) | ||
subscription, err := offRamp.WatchCommitReportAccepted(&bind.WatchOpts{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit : have you checked event.Resubscribe
? it comes handy when the subscription gets into flakey rpc error for longer duration run
Quality Gate passedIssues Measures |
No description provided.