Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCIP Load Test utilizing crib setup #15954

Open
wants to merge 44 commits into
base: develop
Choose a base branch
from
Open

CCIP Load Test utilizing crib setup #15954

wants to merge 44 commits into from

Conversation

0xAustinWang
Copy link
Contributor

No description provided.

scheibinger
scheibinger previously approved these changes Jan 21, 2025
Copy link
Contributor

@scheibinger scheibinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

"github.com/smartcontractkit/chainlink/v2/core/gethwrappers/ccip/generated/router"
)

type SeqNumRange struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use ccipocr3.SeqNumRange?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to use the atomic library here to capture race conditions, but i'm open to modifying it if you think that's unnecessary

Copy link
Contributor

@AnieeG AnieeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial Review

deployment/ccip/changeset/cs_ccip_home.go Outdated Show resolved Hide resolved
deployment/ccip/changeset/cs_ccip_home.go Outdated Show resolved Hide resolved
deployment/ccip/changeset/cs_prerequisites.go Outdated Show resolved Hide resolved
deployment/ccip/changeset/state.go Outdated Show resolved Hide resolved
deployment/environment/crib/helpers.go Outdated Show resolved Hide resolved
Comment on lines +35 to +36
WSRPCs []CribRPCs // websocket rpcs to connect to the chain
HTTPRPCs []CribRPCs // http rpcs to connect to the chain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's create new entries instead of modifying this. We might simply want to connect to testnet chains with this. Internal and external would be confusing in that case

deployment/environment/devenv/chain.go Show resolved Hide resolved
integration-tests/testconfig/ccip/load.go Outdated Show resolved Hide resolved
integration-tests/load/ccip/helpers.go Show resolved Hide resolved
}

sink := make(chan *offramp.OffRampCommitReportAccepted)
subscription, err := offRamp.WatchCommitReportAccepted(&bind.WatchOpts{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit : have you checked event.Resubscribe? it comes handy when the subscription gets into flakey rpc error for longer duration run

@0xAustinWang 0xAustinWang requested a review from AnieeG January 22, 2025 04:06
AnieeG
AnieeG previously approved these changes Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants