Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/services/relay/evm/capabilities: extend timeout for TestLogEventTriggerEVMHappyPath flake #15836

Merged
merged 1 commit into from
Jan 3, 2025
Merged

core/services/relay/evm/capabilities: extend timeout for TestLogEventTriggerEVMHappyPath flake #15836

merged 1 commit into from
Jan 3, 2025
+2 −2

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Jan 3, 2025 •
edited
Loading

https://smartcontract-it.atlassian.net/browse/BCF-3462
https://smartcontract-it.atlassian.net/browse/BCF-3447

This fix also affects TestLogEventTriggerCursorNewLogs

--- FAIL: TestLogEventTriggerEVMHappyPath (188.06s)
    logger.go:146: 2025-01-03T16:37:48.603Z	INFO	LogEventTriggerCapabilityService	logevent/service.go:139	Starting LogEventTriggerCapabilityService	{"version": "unset@unset"}
    logger.go:146: 2025-01-03T16:37:48.611Z	INFO	LogEventTriggerCapabilityService	logevent/service.go:116	RegisterTrigger	{"version": "unset@unset", "triggerId": "logeventtrigger_log1", "WorkflowID": ""}
    logger.go:146: 2025-01-03T16:37:48.611Z	DEBUG	LogPoller	logpoller/log_poller.go:1104	Latest blocks read from chain	{"version": "unset@unset", "latest": 3, "finalized": 1}
    logger.go:146: 2025-01-03T16:37:48.612Z	DEBUG	LogPoller	logpoller/log_poller.go:997	Polling for logs	{"version": "unset@unset", "currentBlockNumber": 1}
    logger.go:146: 2025-01-03T16:37:48.613Z	DEBUG	LogPoller	logpoller/log_poller.go:1104	Latest blocks read from chain	{"version": "unset@unset", "latest": 3, "finalized": 1}
    logger.go:146: 2025-01-03T16:37:48.614Z	INFO	LogPoller	logpoller/log_poller.go:959	Do not have previous block, first poll ever on new chain or after backfill	{"version": "unset@unset", "currentBlockNumber": 1}
    logger.go:146: 2025-01-03T16:37:48.615Z	DEBUG	LogPoller	logpoller/log_poller.go:1064	Unfinalized log query	{"version": "unset@unset", "logs": 0, "currentBlockNumber": 1, "blockHash": "0x747b40554862ff028bb55119cb00f34916069a23b7e6caa0c651f960d27ec270", "timestamp": "2025-01-02T16:37:48.000Z"}
    logger.go:146: 2025-01-03T16:37:49.611Z	INFO	LogEventTriggerCapabilityService.LogEventTrigger.	logevent/trigger.go:144	Polling event logs from ContractReader using QueryKey at	{"version": "unset@unset", "time": "2025-01-03T16:37:49.611Z", "startBlockNum": 0, "cursor": ""}
    log_event_trigger_test.go:139: 
        	Error Trace:	/home/runner/work/chainlink/chainlink/core/services/relay/evm/capabilities/log_event_trigger_test.go:139
        	            				/home/runner/work/chainlink/chainlink/core/services/relay/evm/capabilities/log_event_trigger_test.go:64
        	Error:      	Received unexpected error:
        	            	timeout waiting for Log1 event from ContractReader
        	Test:       	TestLogEventTriggerEVMHappyPath
    logger.go:146: 2025-01-03T16:38:03.614Z	INFO	LogEventTriggerCapabilityService	logevent/service.go:149	Stopping LogEventTriggerCapabilityService	{"version": "unset@unset"}
    logger.go:146: 2025-01-03T16:40:56.642Z	INFO	LogEventTriggerCapabilityService.LogEventTrigger.	logevent/trigger.go:138	Closing trigger server for (waiting for waitGroup)	{"version": "unset@unset", "ChainID": "1337", "ContractName": "LogEmitter", "ContractAddress": "0x78Dc4B49F81Eed7F64C387677102c43BE5245a9a", "ContractEventName": "Log1"}
    logger.go:146: 2025-01-03T16:40:56.642Z	DEBUG	LogPoller	logpoller/log_poller.go:1064	Unfinalized log query	{"version": "unset@unset", "logs": 0, "currentBlockNumber": 2, "blockHash": "0x8e6bfc6ad47bfa2c9a127e6ebc7fb26bd790e3d9c01013bbbd711c6797498e50", "timestamp": "2025-01-03T16:37:48.000Z"}
    logger.go:146: 2025-01-03T16:40:56.643Z	WARN	LogPoller	logpoller/log_poller.go:935	Unable to get currentBlock	{"version": "unset@unset", "err": "context canceled", "currentBlockNumber": 3}
    logger.go:146: 2025-01-03T16:40:56.643Z	ERROR	LogPoller	logpoller/log_poller.go:1051	Unable to get current block	{"version": "unset@unset", "err": "context canceled"}
        github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller.(*logPoller).PollAndSaveLogs
        	/home/runner/work/chainlink/chainlink/core/chains/evm/logpoller/log_poller.go:1051
        github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller.(*logPoller).run
        	/home/runner/work/chainlink/chainlink/core/chains/evm/logpoller/log_poller.go:652
FAIL
FAIL	github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/capabilities	[188](https://github.com/smartcontractkit/chainlink/actions/runs/12600768168/job/35120522349#step:15:189).406s

@jmank88 jmank88 requested review from a team as code owners January 3, 2025 16:52
@jmank88 jmank88 requested a review from pavel-raykov January 3, 2025 16:52
@jmank88 jmank88 enabled auto-merge January 3, 2025 16:53
kidambisrinivas
kidambisrinivas approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@kidambisrinivas kidambisrinivas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kidambisrinivas
kidambisrinivas reviewed Jan 3, 2025
View reviewed changes
core/services/relay/evm/capabilities/log_event_trigger_test.go
@@ -135,7 +135,7 @@ func emitLogTxnAndWaitForLog(t *testing.T,

for _, expectedLogVal := range expectedLogVals {
// Wait for logs with a timeout
_, output, err := testutils.WaitForLog(th.BackendTH.Lggr, log1Ch, 15*time.Second)
_, output, err := testutils.WaitForLog(th.BackendTH.Lggr, log1Ch, tests.WaitTimeout(t))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we set it to 1 minute, just in case?
DefaultTimeout is 30s

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "just in case"? WaitTimeout is calibrated to the test deadline, so it already represents an extreme version of "just in case", by waiting until the whole suite is about to quit.

@jmank88 jmank88 force-pushed the flake-TestLogEventTriggerEVMHappyPath branch from 09eb1f4 to 9363c69 Compare January 3, 2025 22:25
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@jmank88 jmank88 added this pull request to the merge queue Jan 3, 2025
Merged via the queue into develop with commit 0fb7546 Jan 3, 2025
168 of 169 checks passed
@jmank88 jmank88 deleted the flake-TestLogEventTriggerEVMHappyPath branch January 3, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kidambisrinivas kidambisrinivas kidambisrinivas approved these changes

@pavel-raykov pavel-raykov pavel-raykov approved these changes

@AKhozya AKhozya AKhozya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmank88 @AKhozya @kidambisrinivas @pavel-raykov