Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCIP-4737 compile using foundry #15829

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from
Draft

CCIP-4737 compile using foundry #15829

wants to merge 20 commits into from

Conversation

RensR
Copy link
Contributor

@RensR RensR commented Jan 3, 2025

Compile CCIP and Shared using Foundry instead of using Python to install solc-select. Because it's using Foundry now, it uses the settings from the foundry.toml file, leading to a single source of truth.

One design choice taken was to clean up go_generate, which did come at a cost, which I would argue is a feature, of no longer being able to overwrite the contract name for the gethwrapper. The old generation/generate/wrap.go is still available for backwards compatibility, which still allows this. Because of this new restriction, this PR renamed a few wrongly named CCIP contracts.

Another minor change is the removal of out-of-package wrapper compilation, meaning ccip would compile a wrapper for a contract in shared. This should always be done in the shared wrapper generation.

These compilation changes should be applied for each product.

@RensR RensR changed the title compile using foundry CCIP-4737 compile using foundry Jan 3, 2025
@RensR RensR force-pushed the compile-using-foundry branch from f720676 to 6e2511e Compare January 3, 2025 10:39
bump shared compilation version to 0.8.24
@RensR RensR force-pushed the compile-using-foundry branch from 6e2511e to 538dfb1 Compare January 3, 2025 10:40
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Jan 3, 2025
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Jan 3, 2025
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/cuddly-roses-vanish.md

This PR has been linked to Solidity Review Jira issue: CCIP-3966

@smartcontractkit smartcontractkit deleted a comment from github-actions bot Jan 3, 2025
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Jan 3, 2025
@RensR RensR force-pushed the compile-using-foundry branch from e578206 to f64013a Compare January 3, 2025 11:40
@RensR RensR force-pushed the compile-using-foundry branch from f96bb5e to 99b29e8 Compare January 3, 2025 14:36
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Jan 3, 2025
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Jan 3, 2025
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Static analysis results are available

Hey @RensR, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

AER Report: CI Core ran successfully ✅

aer_workflow , commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant