-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP-4737 compile using foundry #15829
base: develop
Are you sure you want to change the base?
Conversation
abis have changed in order, no bytecode diff
f720676
to
6e2511e
Compare
bump shared compilation version to 0.8.24
6e2511e
to
538dfb1
Compare
Solidity Review Jira issueHey! We have taken the liberty to link this PR to a Jira issue for Solidity Review. This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one. Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: This PR has been linked to Solidity Review Jira issue: CCIP-3966 |
e578206
to
f64013a
Compare
f96bb5e
to
99b29e8
Compare
I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:
|
AER Report: CI Core ran successfully ✅ |
Quality Gate passedIssues Measures |
Compile CCIP and Shared using Foundry instead of using Python to install solc-select. Because it's using Foundry now, it uses the settings from the foundry.toml file, leading to a single source of truth.
One design choice taken was to clean up
go_generate
, which did come at a cost, which I would argue is a feature, of no longer being able to overwrite the contract name for the gethwrapper. The oldgeneration/generate/wrap.go
is still available for backwards compatibility, which still allows this. Because of this new restriction, this PR renamed a few wrongly named CCIP contracts.Another minor change is the removal of out-of-package wrapper compilation, meaning
ccip
would compile a wrapper for a contract inshared
. This should always be done in theshared
wrapper generation.These compilation changes should be applied for each product.