Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solana plugin #15820

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Solana plugin #15820

wants to merge 7 commits into from

Conversation

archseer
Copy link
Contributor

@archseer archseer commented Jan 2, 2025

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@huangzhen1997
Copy link
Contributor

Thanks for making this, looks good to me. Do you want to merge this or create it as a base branch ?

@archseer archseer marked this pull request as ready for review January 3, 2025 11:36
@archseer archseer requested review from a team as code owners January 3, 2025 11:36
huangzhen1997
huangzhen1997 previously approved these changes Jan 3, 2025
View reviewed changes
@archseer archseer enabled auto-merge January 6, 2025 14:58
winder
winder reviewed Jan 7, 2025
View reviewed changes
core/capabilities/ccip/delegate.go
Comment on lines -254 to -256
if networkType != relay.NetworkEVM {
return nil, fmt.Errorf("unsupported chain type: %s", networkType)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check can still be performed by the oracle creator using something like _, supported := oraclecreator.plugins[networkType]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the check because it should be fine to declare OCR2 keys for chains that are currently unsupported, those keys will just be unused (a similar change is needed in transmitters). This way we won't even need to redeploy jobspecs when new chains with existing keys add CCIP support.

The jobspec code further down also works similarly: it simply exposes all available key types

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
2 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winder winder winder left review comments

@prashantkumar1982 prashantkumar1982 prashantkumar1982 left review comments

@cedric-cordenier cedric-cordenier cedric-cordenier left review comments

@huangzhen1997 huangzhen1997 huangzhen1997 left review comments

@EasterTheBunny EasterTheBunny Awaiting requested review from EasterTheBunny EasterTheBunny is a code owner automatically assigned from smartcontractkit/foundations

@rstout rstout Awaiting requested review from rstout rstout is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

@b-gopalswami b-gopalswami Awaiting requested review from b-gopalswami b-gopalswami is a code owner automatically assigned from smartcontractkit/ccip-offchain

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@archseer @huangzhen1997 @winder @cedric-cordenier @prashantkumar1982