Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump geth to v1.14.12 #15375

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

bump geth to v1.14.12 #15375

wants to merge 2 commits into from

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Nov 21, 2024

It looks like params.Version was removed, so we will have to find a work around.

Copy link
Contributor

github-actions bot commented Nov 21, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Core Tests (go_core_tests) , test-scripts , Core Tests (go_core_tests_integration) , GolangCI Lint (core/scripts) , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (.) , Core Tests (go_core_fuzz) , GolangCI Lint (integration-tests/load) , Core Tests (go_core_race_tests) , GolangCI Lint (integration-tests) , GolangCI Lint (deployment) , lint , SonarQube Scan

1. Git diff detected changes:

Job ID: Ensure clean after generate

Source of Error:
Ensure clean after generate	2025-01-22T01:01:34.9176552Z ##[error]Process completed with exit code 1.

Why: The git diff --stat --cached --exit-code command detected changes in the repository after the generate step, indicating that the repository is not clean.

Suggested fix: Ensure that the generate step does not introduce any changes or commit the changes before running the git diff command.

2. TestLogPoller_PollAndSaveLogs failed:

Job ID: Run tests

Source of Error:
Run tests	2025-01-22T01:00:12.0609881Z --- FAIL: TestLogPoller_PollAndSaveLogs (4.08s)
Run tests	2025-01-22T01:00:12.0610598Z --- FAIL: TestLogPoller_PollAndSaveLogs/fixed_finality_depth_without_finality_tag (2.05s)
Run tests	2025-01-22T01:00:12.0903101Z 	Test: 	TestLogPoller_PollAndSaveLogs/fixed_finality_depth_without_finality_tag
Run tests	2025-01-22T01:00:12.0904700Z --- FAIL: TestLogPoller_PollAndSaveLogs/chain_finality_in_use (2.03s)
Run tests	2025-01-22T01:00:12.0958389Z 	Test: 	TestLogPoller_PollAndSaveLogs/chain_finality_in_use
Run tests	2025-01-22T01:00:12.0960481Z --- FAIL: TestLogPoller_PollAndSaveLogsDeepReorg (4.26s)
Run tests	2025-01-22T01:00:12.1110110Z 	Test: 	TestLogPoller_PollAndSaveLogsDeepReorg/fixed_finality_depth_without_finality_tag
Run tests	2025-01-22T01:00:12.1112435Z 	Test: 	TestLogPoller_PollAndSaveLogsDeepReorg/chain_finality_in_use
Run tests	2025-01-22T01:01:27.0784246Z FAIL
Run tests	2025-01-22T01:01:27.0784718Z FAIL	github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller	10.086s

Why: The TestLogPoller_PollAndSaveLogs test cases failed, indicating issues with the log poller functionality, specifically with handling finality depth and chain finality.

Suggested fix: Investigate the test cases to ensure that the log poller correctly handles finality depth and chain finality scenarios. Adjust the test setup or the log poller implementation as needed to pass the tests.

3. TestLogPoller_PollAndSaveLogsDeepReorg failed:

Job ID: Run tests

Source of Error:
Run tests	2025-01-22T01:00:12.0960481Z --- FAIL: TestLogPoller_PollAndSaveLogsDeepReorg (4.26s)
Run tests	2025-01-22T01:00:12.1110110Z 	Test: 	TestLogPoller_PollAndSaveLogsDeepReorg/fixed_finality_depth_without_finality_tag
Run tests	2025-01-22T01:00:12.1112435Z 	Test: 	TestLogPoller_PollAndSaveLogsDeepReorg/chain_finality_in_use
Run tests	2025-01-22T01:01:27.0784246Z FAIL
Run tests	2025-01-22T01:01:27.0784718Z FAIL	github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller	10.086s

Why: The TestLogPoller_PollAndSaveLogsDeepReorg test cases failed, indicating issues with the log poller functionality during deep reorganization scenarios.

Suggested fix: Investigate the test cases to ensure that the log poller correctly handles deep reorganization scenarios. Adjust the test setup or the log poller implementation as needed to pass the tests.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

RensR
RensR previously approved these changes Nov 22, 2024
@jmank88
Copy link
Contributor Author

jmank88 commented Nov 22, 2024

I thought that CI was just flaking, but this appears to legitimately break some log poller tests 🤔

Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 22, 2025
@jmank88 jmank88 removed the Stale label Jan 22, 2025
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 188939d (geth-1.14.12).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestMain 0.00% true false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/gethwrappers true 0s @smartcontractkit/foundations, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and ae4137b (geth-1.14.12).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestMain 0.00% true false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/gethwrappers true 0s @smartcontractkit/foundations, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants