CCIP-4152 Token transfer test #15130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makramkd
reviewed
Nov 6, 2024
| @@ -93,7 +93,7 @@ func TestAddLane(t *testing.T) { | |||
| startBlock := latesthdr.Number.Uint64() | |||
| // Send traffic on the first lane and it should not be processed by the plugin as onRamp is disabled | |||
| // we will check this by confirming that the message is not executed by the end of the test | |||
| seqNum1 := TestSendRequest(t, e.Env, state, chain1, chain2, false) | |||
| seqNum1 := TestSendRequest(t, e.Env, state, chain1, chain2, false, nil) | |||
There was a problem hiding this comment.
Potentially simple abstraction here might be a RequestBuilder or similar, and then a simple SendRequest function that literally just sends it to the router.
There was a problem hiding this comment.
Yeah, let's have that in a followup
| Decimals: ccdeploy.LinkDecimals, | ||
| DeviationPPB: cciptypes.NewBigIntFromInt64(1e9), | ||
| }, | ||
| ) |
There was a problem hiding this comment.
Do we need that Weth token info from the other PR? #15131
makramkd
approved these changes
Nov 6, 2024
dimkouv
approved these changes
Nov 6, 2024
mateusz-sekara
changed the title
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports