CCIP-4114 refactor token pool tests for one function per file #15119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RensR
reviewed
Nov 5, 2024
contracts/src/v0.8/ccip/test/pools/USDC/USDCTokenPool.lockOrBurn.t.sol
Outdated
Show resolved
Hide resolved
RensR
reviewed
Nov 5, 2024
| assertEq(address(s_burnMintERC677), address(s_pool.getToken())); | ||
| assertEq(address(s_mockRMN), s_pool.getRmnProxy()); | ||
| assertEq(false, s_pool.getAllowListEnabled()); | ||
| assertEq(type(uint256).max, s_burnMintERC677.allowance(address(s_pool), address(s_pool))); | ||
| assertEq("BurnFromMintTokenPool 1.5.0", s_pool.typeAndVersion()); | ||
| } | ||
|
|
||
| function test_PoolBurn_Success() public { |
There was a problem hiding this comment.
Why did you change the casing on these? The test rename comes after and these new names are not following the final naming scheme anyway?
There was a problem hiding this comment.
it was giving annoying linting errors about the case which is why but I will revert it.
RensR
approved these changes
Nov 5, 2024
RyanRHall
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor tests in the token pools folder to better align with new formatting and solhint rules. One function per file. Hybrid USDC Token pool tests were also modified in name to align with the naming convention.
Previous Lines in the ccip.gas-snapshot: 748
Current lines: 756