-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: changelog generation formatting RE-3152 #15060
Conversation
Quality Gate passedIssues Measures |
nice! should we also do this for changeset in |
@momentmaker, it's already included in this PR. |
ahh sorry - totally missed it |
Would it be possible to give an example of the changelog generation before and after this change? Also, stupid question - could one just use '@changesets/changelog-github' and then do some filtering to remove usernames? (or is this as hard as forking the changelog) |
i don't think you can config it and what's @erikburt created the custom formatter. and the example he gave in the description is the after and you can see the current changelog to see how currently is. |
Thanks, and what is the purpose of hiding the usernames - is this some privacy issue? |
don't think so but more so a request from the core team - probably because of annoyance of getting tagged |
Ok, @erikburt could you please update the description with the motivation for this change. Thanks! |
Changes
@changesets/changelog-github
to a local file which doesn't include users in the changelog generationpackage.json
s to remove the unused dependency, and explicitly declare the pre-existing transitive dependency which is now referenced in the changelog generation codeTesting
Tested locally, new format of changelog is like:
RE-3152