bump geth to 1.14.11 #15041
Merged
bump geth to 1.14.11 #15041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
AER Report: CI Coreaer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Find New Flaky Tests In Root Project / Find Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Find New Flaky Tests In Deployment Project / Find Tests To Run , Find New Flaky Tests In Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/ccip_integration_tests... , Find New Flaky Tests In Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller) , Find New Flaky Tests In Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/vrf/v2) , Find New Flaky Tests In Deployment Project / Run Tests (github.com/smartcontractkit/chainlink/deployment/ccip/changeset) , Flakey Test Detection , SonarQube Scan , Find New Flaky Tests In Root Project / Report , Find New Flaky Tests In Deployment Project / Report 1. Race condition detected in tests:[Core Tests (go_core_race_tests)]Source of Error:Suggested fix: Investigate the tests and the code they cover to identify shared resources being accessed concurrently. Use synchronization mechanisms like mutexes or channels to ensure safe concurrent access. 2. Test failures encountered:[Core Tests (go_core_tests)]Source of Error:Suggested fix: Review the test output logs to identify which tests failed and the reasons for their failure. Address the underlying issues in the code or the tests themselves to resolve the failures. AER Report: Operator UI CI ran successfully ✅ |
|
…into geth-1.14.11
connorwstein
reviewed
Nov 5, 2024
| 10, | ||
| ) | ||
| require.NoError(t, err) | ||
| return len(reports) == numReports | ||
| return len(reports) == numReports-1 |
There was a problem hiding this comment.
I believe this was a bad merge actually, develop has -1 here.
connorwstein
reviewed
Nov 5, 2024
| // CCIP relies on block timestamps, but SimulatedBackend uses by default clock starting from 1970-01-01 | ||
| // This trick is used to move the clock closer to the current time. We set first block to be X hours ago. | ||
| // Tests create plenty of transactions so this number can't be too low, every new block mined will tick the clock, | ||
| // if you mine more than "X hours" transactions, SimulatedBackend will panic because generated timestamps will be in the future. |
There was a problem hiding this comment.
It seems the new simulated backend doesn't care about timestamps in the future so we don't need to do this anymore
connorwstein
requested review from
george-dorin,
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xAustinWang
and removed request for
a team
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
* bump geth v1.13.14; rm hack; fix simulated backend; run make generate * Update simulated geth client wrapper & LogPoller tests (#13204) * Re-run make generate, fix fluxmonitorv2 & ocr2keeper tests * Update SimulatedBackendClient to wrap simulated.Backend & simulated.Client ( instead of deprecated backends.SimulatedBackendClient ) * Update LogPoller helper * Add support for switching rpc clients in simulated geth * Fix TestLogPoller_BackupPollAndSaveLogsSkippingLogsThatAreTooOld This test relied on markBlockFinalized() which has been replaced with finalizedBlocksThrough(). Just needed some slight adjustments to keep testing the same thing. * Fix TestLogPoller_ReorgDeeperThanFinality * Fix Test_PollAndSavePersistsFinalityInBlocks * Fix Test_PollAndQueryFinalizedBlocks * update listener_v2_log_listener_test * Fix chainreader & config poller tests * Update keeper integration tests * Re-run make generate * Update BackupLogPoller test Add RegisterHeadNumberCallback() to SimulatedBackendClient, so we can trigger an rpc failover event just after reading a particular block, but before the logs get read for that block. This is the race condition that can happen on optimism chain which BackupPoller was designed to address * . * Update TestLogPoller_PollAndSaveLogsDeepReorg * Not sure how this was working before Presumably, the older verison of simulated.Backend would fill in fake timestamps instead of real ones? * Update TestLogPoller_PollAndSaveLogs * Update TestLogPoller_Blocktimestamps The new Simulated Geth made two changes which affected this test 1. The automatic time interval added to each new block is now 1ns instead of 1s 2. AdjustTime() now automatically calls Commit() so it no longer needs to be called aftewards * Update TestLogPoller_BackupPollAndSaveLogsWithPollerNotWorking * Address PR review comments - Consolidate go-ethereum imports - Remove extra geth-wrapper changes * Update types in vrf tests * Update keepers, fluxmointor, transmitter,ocr test types * re-generate KeystoneForwarder * Replace optimismMode with chainFamily enum * Update more types GenesisAlloc, GenesisAccount, llo * Fix some more compilation errors (fluxmonitor2, vrf, ocr2, functions) * Fix lint errors, remove unused logpoller test definitions * Run go-generate again on KeystoneForwarder * Re-run "make generate" one more time, this time without any failures aside from the // error at the end that's in CI as well. * Re-generate generation version db for keystone * cleanup * make generate * cleanup * race-free simulated backend commits * race free commits * fix tests by adding commits * bump geth to 1.13.15 * fix more races * Remove inconsistent named param from return signature * insert temporary skips * make generate * skip more tests * skip more tests; fill zeroed timestamp on insert * fix race for commit * core/services/ocr2/plugins/ocr2keeper/evmregistry/v21/logprovider: run log poller * re-enable some tests * consolidate finalization helpers * fix some tests with real timestamps * simplify * core/services/vrf/solidity_cross_tests: raise gas estimate upper bound in TestMeasureRandomnessRequestGasCost * cleanup and patch for geth bug * new geth error; vrf test fixes * fix ccip tests * fix clo tests * more fixes * fix test var name * fix compile error * upgrade to 14.7 * fix lint * lint issues * make generate * fix more tests * skip failing tests * skip tests; linter issues * fix race & lint issues * BCFR-1047 Fix HT Tests (#14807) * Simulated defaults (#14986) * Simulated defaults * Direct request works * Fix config tests * AsyncEthTx * OCR + FM * Keepers * Functions * Bunch of keeper and VRF tests * More vrf tests * Cleanup * Fix a race * core/chains/evm/txmgr: fix TestEthBroadcaster_ProcessUnstartedEthTxs_OptimisticLockingOnEthTx * core/gethwrappers: regenerate * bump geth to 1.14.11 (#15041) * bump geth to 1.14.11 * remove AdjustTime hacks * Try replace in integration tests * Copy replace around * Preserve fork behaviour * generate * tidy * Work around geth, fix timestamp test * Fix docstring * Fix reader test * Linter * Re-enable CCIP deployment tests * Mod + lint * Remove cltest dependency which invokes pgtest init --------- Co-authored-by: connorwstein <connor.stein@mail.mcgill.ca> * Another cltest remove * Go mod tidy * Regen lint and fix LLO test * Enable some more tests * core: prefer simulated backend interface in order to wrap with syncBackend * fix race: cleanup int conversion * lint * lint & fix * lint * lint * unskip and fix * Fix TestIntegration_OCR2_plugins * Fix more OCR tests * update t.Skip() messages * update changeset * Resurrect CCIP tests * Lint * replaces * lint --------- Co-authored-by: Domino Valdano <domino.valdano@smartcontract.com> Co-authored-by: Domino Valdano <2644901+reductionista@users.noreply.github.com> Co-authored-by: AnieeG <anindita.ghosh@smartcontract.com> Co-authored-by: Dmytro Haidashenko <34754799+dhaidashenko@users.noreply.github.com> Co-authored-by: Connor Stein <connor.stein@mail.mcgill.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing out a bump to 1.14.11 with a
replace github.com/btcsuite/btcd/btcec/v2 => github.com/btcsuite/btcd/btcec/v2 v2.3.2