CCIP-3862 Add tokenDestGasOverhead to CalculateMessageMaxGas #14964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstout
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xnogo
rstout
force-pushed
the
AddTokenDestGasOverhead
branch
4 times, most recently
from
0353073 to
367e75a
Compare
rstout
changed the title
rstout
force-pushed
the
AddTokenDestGasOverhead
branch
from
367e75a to
335106c
Compare
rstout
force-pushed
the
AddTokenDestGasOverhead
branch
from
335106c to
e788728
Compare
0xnogo
reviewed
Oct 28, 2024
winder
reviewed
Oct 28, 2024
winder
previously approved these changes
Oct 28, 2024
mateusz-sekara
previously approved these changes
Oct 28, 2024
rstout
force-pushed
the
AddTokenDestGasOverhead
branch
2 times, most recently
from
89c1ad1 to
a7509fd
Compare
Also adds a TODO to update the iface to return an error
rstout
force-pushed
the
AddTokenDestGasOverhead
branch
from
a7509fd to
ed3f56e
Compare
|
winder
approved these changes
Oct 28, 2024
| // CalculateMessageMaxGasWithError computes the maximum gas overhead for a message. | ||
| // TODO: Add destGasOverhead, see: | ||
| // https://github.com/smartcontractkit/chainlink/blob/23452266132228234312947660374fb393e96f1a/contracts/src/v0.8/ccip/FeeQuoter.sol#L97 | ||
| func (gp EstimateProvider) CalculateMessageMaxGasWithError(msg cciptypes.Message) (uint64, error) { |
There was a problem hiding this comment.
CalculateMessageMaxGasWithError naming implies to me that we are doing something useful with the error. Panic'ing is ...useful, just not the usual application. I see both API's are public and exportable - is there a plan to deprecate CalculateMessageMaxGas
patrickhuie19
approved these changes
Oct 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
vyzaldysanchez
approved these changes
Oct 29, 2024
This was referenced Oct 21, 2024
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.