Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support enable/disable JDs via API #14937

Merged
merged 3 commits into from
Oct 27, 2024
Merged

Support enable/disable JDs via API #14937

merged 3 commits into from
Oct 27, 2024

Conversation

ChrisAmora
Copy link
Contributor

@ChrisAmora ChrisAmora commented Oct 24, 2024 •
edited
Loading

https://smartcontract-it.atlassian.net/browse/DPA-1066
Allow operators to enable and disable JDs

@ChrisAmora ChrisAmora marked this pull request as ready for review October 24, 2024 14:07
@ChrisAmora ChrisAmora requested review from a team, eutopian and yevshev as code owners October 24, 2024 14:07
@ChrisAmora ChrisAmora requested a review from Atrax1 October 24, 2024 14:07
giogam
giogam reviewed Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@giogam giogam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just think that we should disabledAt instead of deletedAt

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
87.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@krehermann krehermann added this pull request to the merge queue Oct 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 26, 2024
@giogam giogam added this pull request to the merge queue Oct 27, 2024
Merged via the queue into develop with commit 3ad089f Oct 27, 2024
132 checks passed
@giogam giogam deleted the feat/enable-disable-manager branch October 27, 2024 19:12
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Draft
@chainchad chainchad mentioned this pull request Nov 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request Nov 2, 2024
Draft
This was referenced Oct 21, 2024
Draft
Draft
Draft
Draft
This was referenced Nov 16, 2024
Draft
Draft
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Draft
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krehermann krehermann krehermann approved these changes

@giogam giogam giogam approved these changes

@eutopian eutopian Awaiting requested review from eutopian eutopian is a code owner

@yevshev yevshev Awaiting requested review from yevshev

@Atrax1 Atrax1 Awaiting requested review from Atrax1 Atrax1 is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisAmora @giogam @krehermann