Improve CCIP Contract Reader Querying usage #14935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
ilija42
force-pushed
the
CCIP-2896-improve-ccip-contract-reader-querying
branch
from
e895eb2 to
0f768d5
Compare
ilija42
changed the title
ilija42
requested review from
krehermann,
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xnogo
ilija42
force-pushed
the
CCIP-2896-improve-ccip-contract-reader-querying
branch
from
96018a4 to
2d78005
Compare
ilija42
force-pushed
the
CCIP-2896-improve-ccip-contract-reader-querying
branch
from
2d78005 to
e866958
Compare
ilija42
force-pushed
the
CCIP-2896-improve-ccip-contract-reader-querying
branch
from
e866958 to
c2c482e
Compare
|
patrick-dowell
previously approved these changes
Oct 30, 2024
There was a problem hiding this comment.
I think the code itself is okay as is, but it's pretty hard to follow and seems like it'd be a little fragile if someone came in and tried to change things.
I'd recommend more code comments to explain what the various methods are actually doing and, in addition, consider adding unit tests to the helper methods themselves to verify that they are calculating the indices properly. This would make it easier for someone to come in and modify things without breaking some of the high level tests and struggle to figure out what went wrong.
ilija42
force-pushed
the
CCIP-2896-improve-ccip-contract-reader-querying
branch
2 times, most recently
from
91a43df to
71ac32c
Compare
ilija42
force-pushed
the
CCIP-2896-improve-ccip-contract-reader-querying
branch
from
31ccb25 to
605fbf6
Compare
ilija42
requested review from
Farber98,
silaslenihan,
makramkd,
patrick-dowell and
mateusz-sekara
mateusz-sekara
approved these changes
Nov 6, 2024
silaslenihan
approved these changes
Nov 6, 2024
ilija42
changed the title
EasterTheBunny
approved these changes
Nov 6, 2024
jmank88
approved these changes
Nov 6, 2024
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related chainlink-ccip PR smartcontractkit/chainlink-ccip#267
Also relates to
CCIP-3866
and
CCIP-3865