various Solidity Foundry updates #14866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…run also for tests, add back static analysis
Tofel
force-pushed
the
tt-1728_tt-1784_tt-1785-various-solidity-fixes
branch
from
de6e810 to
500f4ec
Compare
AER Report: CI Core ran successfully ✅ |
gheorghestrimtu
approved these changes
Oct 22, 2024
Tofel
commented
Oct 22, 2024
| @@ -252,9 +252,286 @@ jobs: | |||
| artifact-name: code-coverage-report-${{ matrix.product.name }} | |||
| working-directory: ./contracts | |||
|
|
|||
| # runs only if non-test contracts were modified; scoped only to modified or added contracts | |||
| analyze: | |||
There was a problem hiding this comment.
I added back whole static analysis job
Tofel
commented
Oct 22, 2024
| path: contracts/configs | ||
| retention-days: 7 | ||
| if-no-files-found: error | ||
| include-hidden-files: true |
There was a problem hiding this comment.
this is the only real change vs previous version, required as config files start with a .
Tofel
commented
Oct 22, 2024
| solidity-forge-fmt: | ||
| name: Forge fmt ${{ matrix.product.name }} | ||
| if: ${{ needs.changes.outputs.non_src_changes == 'true' || needs.changes.outputs.not_test_sol_modified == 'true' }} | ||
| if: ${{ needs.changes.outputs.non_src_changes == 'true' || needs.changes.outputs.sol_modified_added == 'true' }} |
There was a problem hiding this comment.
we will now run forge fmt when any Solidity files change, not only non-test ones
Tofel
commented
Oct 22, 2024
| with: | ||
| name: tmp-* | ||
|
|
||
| check-tests-results: |
There was a problem hiding this comment.
new job that checks for results of the test matrix, we will set it as a required job
Tofel
commented
Oct 22, 2024
| @@ -285,3 +562,16 @@ jobs: | |||
| working-directory: contracts | |||
| env: | |||
| FOUNDRY_PROFILE: ${{ matrix.product.name }} | |||
|
|
|||
| check-fmt-results: | |||
There was a problem hiding this comment.
new job that checks for results of the formatting matrix, we will set it as a required job
momentmaker
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
also the name at line 2
|
momentmaker
added a commit
that referenced
this pull request
Oct 23, 2024
* develop: rm gethwrappers from codeowners offchain (#14919) CCIP-3899 fix sender encoding (#14877) ccip: use unknown address type. (#14836) [chore] Add changeset entry for RequestRoundTracker fix (#14912) various Solidity Foundry updates (#14866) CCIP-3710 create new custom calldata L1 (DA) gas oracle (#14710) CCIP owns smoke test (#14906) core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion (#14861) CCIP-3730 Misc ccip onchain changes (#14845) Chain fee integration tests (#14829) release/2.17.0 -> develop (#14721) Solana: re-enable disabled test with updated version (#14892)
cedric-cordenier
pushed a commit
that referenced
this pull request
Oct 24, 2024
* add two new aggregate jobs for tests and formatting, make formatting run also for tests, add back static analysis * update AER version, post solidity review ticket comment only if such ticket was found * revert AER version change * revert changes to llm aer file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a couple of changes:
Tests: