Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mantle NonceTooLow Error #14859

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Add Mantle NonceTooLow Error #14859

merged 2 commits into from
Oct 21, 2024

Conversation

ma33r
Copy link
Contributor

@ma33r ma33r commented Oct 21, 2024 •
edited
Loading

What

  • Added a custom client error message for Mantle to capture NonceTooLow error.
  • Closes SHIP-3889

Why

  • During QA for the Mantle CCIP Integration, an error was observed in the prod-testnet cluster where "nonce too low" was not correctly handled (context)

@ma33r ma33r requested review from a team as code owners October 21, 2024 11:51
@ma33r ma33r requested a review from chudilka1 October 21, 2024 11:51
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@dimriou dimriou enabled auto-merge October 21, 2024 13:26
@dimriou dimriou added this pull request to the merge queue Oct 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2024
@matYang matYang added this pull request to the merge queue Oct 21, 2024
Merged via the queue into develop with commit 80b0501 Oct 21, 2024
128 checks passed
@matYang matYang deleted the SHIP-3564/handle-mantle-errors branch October 21, 2024 14:51
This was referenced Oct 21, 2024
Draft
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimriou dimriou dimriou approved these changes

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@matYang matYang matYang approved these changes

@chudilka1 chudilka1 Awaiting requested review from chudilka1 chudilka1 is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ma33r @matYang @cedric-cordenier @dimriou