Handle Hex String in EA Telemetry #14827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxiao-cll
previously approved these changes
Oct 17, 2024
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
george-dorin
requested changes
Oct 17, 2024
cawthorne
changed the title
cawthorne
dismissed stale reviews from cedric-cordenier and pavel-raykov
via
e03d9f6
|
pavel-raykov
approved these changes
Oct 23, 2024
george-dorin
approved these changes
Oct 23, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
* Handle Hex String in Utils.ToDecimal
* add tests
* add changeset
* add #added to changeset
* handle hex strings only in EA Telemetry
* isolate hex tests
* update changset
* lint
* fix error return usage
* fix comment
* fix tests
* lint
* try different return
* test bump
* test bump
* test bump 2
* lint
* lint
* return decimal.Decimal{} instead of decimal.Zero in error case
* update functon comments
* use assert.InDelta instead of assert.Equal
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This was referenced Oct 24, 2024
cedric-cordenier
pushed a commit
that referenced
this pull request
Oct 24, 2024
* Handle Hex String in Utils.ToDecimal
* add tests
* add changeset
* add #added to changeset
* handle hex strings only in EA Telemetry
* isolate hex tests
* update changset
* lint
* fix error return usage
* fix comment
* fix tests
* lint
* try different return
* test bump
* test bump
* test bump 2
* lint
* lint
* return decimal.Decimal{} instead of decimal.Zero in error case
* update functon comments
* use assert.InDelta instead of assert.Equal
KMontag42
pushed a commit
that referenced
this pull request
Oct 24, 2024
* Handle Hex String in Utils.ToDecimal
* add tests
* add changeset
* add #added to changeset
* handle hex strings only in EA Telemetry
* isolate hex tests
* update changset
* lint
* fix error return usage
* fix comment
* fix tests
* lint
* try different return
* test bump
* test bump
* test bump 2
* lint
* lint
* return decimal.Decimal{} instead of decimal.Zero in error case
* update functon comments
* use assert.InDelta instead of assert.Equal
This was referenced Oct 21, 2024
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#DF-20580
The EA Telemetry currently fails for EAs where their result is a hex string:
https://smartcontract-it.atlassian.net/browse/DF-20580
https://chainlink-core.slack.com/archives/C0117GGJB6Y/p1729091653229629
Alternative implementation which edits ToDecimal directly, but effects other services is here:
#14841