Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVSVCS-592 [P0] Secrets encrypt CLI - Add encryptionPublicKey #14709

Merged
merged 22 commits into from
Oct 11, 2024

Conversation

KuphJr
Copy link
Contributor

@KuphJr KuphJr commented Oct 9, 2024

smartcontract-it.atlassian.net/browse/DEVSVCS-592
For ST3, each node is to have its own public key so that users can encrypt secrets for that particular node.

@KuphJr KuphJr requested review from a team as code owners October 9, 2024 21:44
@KuphJr KuphJr requested a review from Atrax1 October 9, 2024 21:44
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Below is an analysis created by an LLM. Be mindful of hallucinations and verify accuracy.

WF: CI Core#57009ef

Error: Failed to Add Nodes

Source of Error:
2024-10-09T21:47:38.873Z	ERROR	ccip/deploy_home_chain.go:217	Failed to add nodes	{"version": "unset@unset", "err": "execution reverted"}
github.com/smartcontractkit/chainlink/integration-tests/deployment/ccip.AddNodes
	/home/runner/work/chainlink/chainlink/integration-tests/deployment/ccip/deploy_home_chain.go:217
github.com/smartcontractkit/chainlink/integration-tests/deployment/ccip.DeployCCIPContracts
	/home/runner/work/chainlink/chainlink/integration-tests/deployment/ccip/deploy.go:166
github.com/smartcontractkit/chainlink/integration-tests/deployment/ccip/changeset.InitialDeployChangeSet
	/home/runner/work/chainlink/chainlink/integration-tests/deployment/ccip/changeset/initial_deploy.go:17
github.com/smartcontractkit/chainlink/integration-tests/deployment/ccip/changeset.TestInitialDeploy
	/home/runner/work/chainlink/chainlink/integration-tests/deployment/ccip/changeset/initial_deploy_test.go:40
testing.tRunner
	/opt/hostedtoolcache/go/1.22.7/x64/src/testing/testing.go:1689

Why:
The error occurred due to a smart contract execution that reverted. This typically indicates that a condition in the smart contract was not met, or an exception was thrown within the contract code during the execution of the AddNodes function.

Suggested fix:
Review the smart contract code related to node addition, particularly any require statements or conditions that could lead to a revert. Ensure that all preconditions expected by the contract are satisfied before calling this function. This might involve setting correct initial states, permissions, or providing necessary arguments. Additionally, consider adding more detailed error logging or revert reasons in the smart contract to provide clearer feedback on why the transaction failed.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Below is an analysis created by an LLM. Be mindful of hallucinations and verify accuracy.

WF: CI Core#ace6ef8

Error 1: Test Failures in Go Core Tests

Source of Error:
Core Tests (go_core_tests)	Run tests	2024-10-09T22:36:51.8410314Z Encountered test failures.
Core Tests (go_core_tests)	Run tests	2024-10-09T22:36:51.8429127Z ##[error]Process completed with exit code 1.

Why:
The error indicates that some tests within the Go core tests suite failed, leading to a non-zero exit code. Specific test failures or panics are not detailed in the provided logs, suggesting that the failure details are either in a different part of the logs or output to a different file or console.

Suggested fix:
Review the test output or detailed logs if available to identify which tests failed and why. Address the specific issues in the failing tests, which could range from assertions failing due to incorrect logic, setup issues, or environmental problems such as unavailable dependencies.

Error 2: Compilation Error in Go Core CCIP Deployment Tests

Source of Error:
Core Tests (go_core_ccip_deployment_tests)	Run tests	2024-10-09T22:27:46.7736983Z ##[error]deployment/keystone/deploy.go:549:45: nodeIDToParams.donToOcr2Nodes undefined (type map[string]capabilities_registry.CapabilitiesRegistryNodeParams has no field or method donToOcr2Nodes)

Why:
The error message indicates a compilation failure due to an undefined field or method donToOcr2Nodes in the type map[string]capabilities_registry.CapabilitiesRegistryNodeParams. This suggests either a typo in the field name, a missing implementation, or incorrect type usage.

Suggested fix:
Check the definition of capabilities_registry.CapabilitiesRegistryNodeParams to confirm if the field donToOcr2Nodes should exist. If it's a typo, correct it to the appropriate field name. If the field is supposed to exist but is missing, update the type definition to include it. Alternatively, if the field should not be accessed directly, review the logic to use the correct method or property.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

WF: CI Core#69e711a

No errors found in this run. 🎉

@app-token-issuer-infra-releng app-token-issuer-infra-releng bot requested a review from a team as a code owner October 9, 2024 23:04
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Below is an analysis created by an LLM. Be mindful of hallucinations and verify accuracy.

WF: CI Core#8095771

Error 1: Test Failure Due to Assertion Error

Source of Error:
Error Trace:	/home/runner/work/chainlink/chainlink/core/services/registrysyncer/syncer_test.go:352
Error: 	Not equal:

Why:
The error occurred because the expected result in the test did not match the actual result. This is a common issue in unit tests where the assertions fail due to changes in the underlying code or incorrect test expectations.

Suggested fix:
Review the test case in syncer_test.go at line 352 to ensure that the expected results align with the current functionality of the code. Update the test expectations or fix the code if there is a bug causing the unexpected output.

Error 2: Test Timeout and Panic

Source of Error:
panic: test timed out after 10m0s

Why:
This error indicates that the test TestCache_EvictAfterSize exceeded the maximum allowed execution time, which is typically set to prevent tests from running indefinitely. This could be due to an infinite loop, excessive processing, or a deadlock within the test or the code being tested.

Suggested fix:
Investigate the implementation of TestCache_EvictAfterSize to identify any potential infinite loops or inefficient operations that could be causing the test to run longer than expected. Optimize the code or adjust the test to ensure it completes within the allowed time. Additionally, check for any synchronization issues or deadlocks that could be halting the test execution.

Copy link
Contributor

github-actions bot commented Oct 10, 2024

WF: CI Core#35ee787

No errors found in this run. 🎉

Copy link
Contributor

@shileiwill shileiwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

github-actions bot commented Oct 10, 2024

WF: CI Core#9a15fbf

No errors found in this run. 🎉

Copy link
Contributor

github-actions bot commented Oct 10, 2024

WF: CI Core#45ad475

No errors found in this run. 🎉

Copy link
Contributor

github-actions bot commented Oct 10, 2024

WF: CI Core#1eabd65

No errors found in this run. 🎉

@KuphJr KuphJr added this pull request to the merge queue Oct 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2024
@infiloop2 infiloop2 added this pull request to the merge queue Oct 11, 2024
Merged via the queue into develop with commit 1560aa9 Oct 11, 2024
166 of 169 checks passed
@infiloop2 infiloop2 deleted the keystone-bytes32-secrets-pub-key branch October 11, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.