-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mercury transmitter can use different codecs for native & link price reports #14631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-cll
commented
Oct 2, 2024
martin-cll
force-pushed
the
ml/mercury-v4-uses-v3-native-link
branch
from
October 2, 2024 08:54
3ef45e4
to
eade2d6
Compare
ro-tex
previously approved these changes
Oct 2, 2024
samsondav
requested changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is implemented incorrectly
You’re supposed to create a different codec and pass that in
Quality Gate passedIssues Measures |
samsondav
approved these changes
Oct 3, 2024
ad0ll
approved these changes
Oct 3, 2024
patrickhuie19
approved these changes
Oct 3, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing the following error with a new v4 Mercury feed in staging testnet:
failed to observe LINK price: failed to decode report: abi: improperly encoded uint32 value\nfailed to observe native price: failed to decode report: abi: improperly encoded uint32 value
.I believe this is caused by a v4 feed that uses a v3 native/link feedId:
fetcher.LatestPrice
here: https://github.com/smartcontractkit/chainlink/blob/develop/core/services/relay/evm/mercury/v4/data_source.go#L110-L149.The fix in this PR is to pass down a new
BenchmarkPriceDecoder
method that switches on the feedId to select the appropriate codec before decoding it for its benchmark price.