Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mercury transmitter can use different codecs for native & link price reports #14631

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

martin-cll
Copy link
Contributor

We are seeing the following error with a new v4 Mercury feed in staging testnet: failed to observe LINK price: failed to decode report: abi: improperly encoded uint32 value\nfailed to observe native price: failed to decode report: abi: improperly encoded uint32 value.

I believe this is caused by a v4 feed that uses a v3 native/link feedId:

The fix in this PR is to pass down a new BenchmarkPriceDecoder method that switches on the feedId to select the appropriate codec before decoding it for its benchmark price.

@martin-cll martin-cll requested review from a team as code owners October 2, 2024 08:50
@martin-cll martin-cll requested a review from krehermann October 2, 2024 08:50
@martin-cll martin-cll force-pushed the ml/mercury-v4-uses-v3-native-link branch from 3ef45e4 to eade2d6 Compare October 2, 2024 08:54
ro-tex
ro-tex previously approved these changes Oct 2, 2024
Copy link
Collaborator

@samsondav samsondav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is implemented incorrectly

You’re supposed to create a different codec and pass that in

@martin-cll martin-cll enabled auto-merge October 3, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants