Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KS-420] Add rate-limiting to Dispatcher #14239

Merged
merged 18 commits into from
Aug 29, 2024
Merged

[KS-420] Add rate-limiting to Dispatcher #14239

merged 18 commits into from
Aug 29, 2024

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented Aug 27, 2024

No description provided.

@bolekk bolekk requested a review from vyzaldysanchez August 27, 2024 01:58
bolekk
bolekk commented Aug 27, 2024
View reviewed changes
core/config/toml/types.go Outdated Show resolved Hide resolved
bolekk
bolekk commented Aug 28, 2024
View reviewed changes
Copy link
Contributor Author

@bolekk bolekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good but some tests are still failing.

core/config/docs/core.toml Outdated Show resolved Hide resolved
docs/CONFIG.md Outdated Show resolved Hide resolved
@bolekk bolekk marked this pull request as ready for review August 28, 2024 16:14
@bolekk bolekk requested a review from a team as a code owner August 28, 2024 16:14
bolekk
bolekk commented Aug 28, 2024
View reviewed changes
core/config/dispatcher_config.go Outdated Show resolved Hide resolved
main_test.go Outdated Show resolved Hide resolved
@bolekk bolekk requested a review from a team August 29, 2024 16:11
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
67.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@vyzaldysanchez vyzaldysanchez added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@bolekk bolekk added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@vyzaldysanchez vyzaldysanchez added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@bolekk bolekk added this pull request to the merge queue Aug 29, 2024
Merged via the queue into develop with commit 674eac3 Aug 29, 2024
134 of 135 checks passed
@bolekk bolekk deleted the feature/KS-420-dispatcher-extra-rate-limits branch August 29, 2024 19:45
This was referenced Aug 29, 2024
Draft
Draft
@github-actions github-actions bot mentioned this pull request Sep 20, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bolekk @vyzaldysanchez @cedric-cordenier