Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto: adjust cron contract imports #13927

Merged
merged 2 commits into from
Aug 6, 2024
Merged

auto: adjust cron contract imports #13927

merged 2 commits into from
Aug 6, 2024

Conversation

FelixFan1992
Copy link
Contributor

Requires Dependencies

Resolves Dependencies

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

LCOV of commit 43609b6 during Solidity Foundry #40604

Summary coverage rate:
  lines......: 98.7% (1838 of 1862 lines)
  functions..: 96.6% (344 of 356 functions)
  branches...: 90.7% (782 of 862 branches)

Files changed coverage rate: n/a

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@FelixFan1992 FelixFan1992 marked this pull request as ready for review August 6, 2024 18:19
@FelixFan1992 FelixFan1992 requested a review from a team as a code owner August 6, 2024 18:19
infiloop2
infiloop2 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@infiloop2 infiloop2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as it was verified offline that bytecode didn't change from develop to this PR offline

@FelixFan1992 FelixFan1992 enabled auto-merge August 6, 2024 18:51
@FelixFan1992 FelixFan1992 added this pull request to the merge queue Aug 6, 2024
Merged via the queue into develop with commit ce90bc3 Aug 6, 2024
118 checks passed
@FelixFan1992 FelixFan1992 deleted the auto-adjust-cron-imports branch August 6, 2024 19:18
momentmaker added a commit that referenced this pull request Aug 6, 2024
@momentmaker
Merge branch 'develop' into re-2756/goreleaser-build-image
800b5bf 
* develop:
  Add finalizer component to TXM (#13638)
  auto: adjust cron contract imports (#13927)
  Set PriceMin to match pip-35 definition (#14014)
  update solana e2e test build deps (#13978)
  fix data race in syncer/launcher (#14050)
  [KS-411] Extra validation for FeedIDs in Streams Codec (#14038)
  [TT-1262] dump pg on failure (#14029)
  ks-409 fix the mock trigger to ensure events are sent (#14047)
  update readme's with information about CL node TOML config (#14028)
  [CCIP-Merge] OCR2 plugins  [CCIP-2942] (#14043)
  [BCF - 3339] - Codec and CR hashed topics support (#14016)
  common version update to head of develop (#14030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infiloop2 infiloop2 infiloop2 approved these changes

@cmalec cmalec cmalec approved these changes

@ibrajer ibrajer Awaiting requested review from ibrajer

@justinkaseman justinkaseman Awaiting requested review from justinkaseman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FelixFan1992 @cmalec @infiloop2