BCF-3276: refactor migrations to use goose provider #13678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krehermann
force-pushed
the
bcf-3276/goose-provider
branch
from
5391199 to
933cd39
Compare
krehermann
commented
Jun 25, 2024
| @@ -10,4 +10,4 @@ CREATE TABLE feeds_managers ( | |||
| updated_at timestamp with time zone NOT NULL | |||
| ); | |||
| -- +goose Down | |||
| DROP TABLE feeds_managers | |||
| DROP TABLE feeds_managers; | |||
There was a problem hiding this comment.
fix a linting issue found by the new version of goose
krehermann
requested review from
jmank88,
samsondav,
vyzaldysanchez and
reductionista
| } | ||
| // hack to work around global go migrations | ||
| // https: //github.com/pressly/goose/issues/782 | ||
| goose.ResetGlobalMigrations() |
There was a problem hiding this comment.
any concerns of the usage of this hack?
There was a problem hiding this comment.
no, goose has already fixed the issue and it will be in a new release soon
vyzaldysanchez
previously approved these changes
Jun 25, 2024
|
Needs a changeset though... Will this be considered a minor change? |
vyzaldysanchez
previously approved these changes
Jul 4, 2024
jmank88
previously approved these changes
Jul 4, 2024
krehermann
force-pushed
the
bcf-3276/goose-provider
branch
from
4da9235 to
909993f
Compare
vyzaldysanchez
approved these changes
Jul 9, 2024
jmank88
approved these changes
Jul 9, 2024
|
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCF-3276
Update goose and refactor migrations to use the newly added
goose.ProviderThis is a concrete step toward supporting multiple migrations providers.