ks-327 remote target wait for initiated threads to finish on close #13524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ettec
force-pushed
the
ks-327-wait-for-go-routine-exit
branch
from
6fa4aef to
1fb68f6
Compare
jmank88
reviewed
Jun 12, 2024
jmank88
reviewed
Jun 12, 2024
ettec
force-pushed
the
ks-327-wait-for-go-routine-exit
branch
from
07a9624 to
db90d08
Compare
ettec
commented
Jun 12, 2024
jmank88
reviewed
Jun 12, 2024
jmank88
reviewed
Jun 12, 2024
bolekk
reviewed
Jun 13, 2024
ettec
force-pushed
the
ks-327-wait-for-go-routine-exit
branch
from
d103dc9 to
737606d
Compare
ettec
force-pushed
the
ks-327-wait-for-go-routine-exit
branch
from
737606d to
cdb5115
Compare
jmank88
reviewed
Jun 13, 2024
ettec
force-pushed
the
ks-327-wait-for-go-routine-exit
branch
from
adc4c93 to
4a203c8
Compare
bolekk
approved these changes
Jun 14, 2024
cedric-cordenier
approved these changes
Jun 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
HenryNguyen5
approved these changes
Jun 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/KS-327
Simplified the client and server Receive methods to be blocking as not required to be non-blocking once the dispatcher is changed to be multithreaded as part of-> https://smartcontract-it.atlassian.net/browse/KS-296