Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keystone] Improve workflow engine test times #12959

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

HenryNguyen5
Copy link
Collaborator

@HenryNguyen5 HenryNguyen5 commented Apr 25, 2024

This PR changes the behaviour of the workflow engine (WFE) + its tests:

  • WFE has test properties that control how init performs retries
  • WFE tests will attempt to resolve a capability only once before failing.
  • WFE tests will immediately resolve a capability rather than waiting for the first retry tick.
  • WFE tests contain a select block to watch for an initialization failure, based on retry failure. If we hit the limit of retries (in this case, 1 try), then we fail the test rather than waiting for a timeout.

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-166-reduce-workflow-engine-test-time branch from d9d8de1 to f779473 Compare April 25, 2024 02:02
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-166-reduce-workflow-engine-test-time branch from f779473 to d6001aa Compare April 25, 2024 02:05
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-166-reduce-workflow-engine-test-time branch from d6001aa to e82cd97 Compare April 25, 2024 02:09
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-166-reduce-workflow-engine-test-time branch from e82cd97 to bc3adc4 Compare April 25, 2024 02:12
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-166-reduce-workflow-engine-test-time branch from bc3adc4 to 1eaf4f9 Compare April 25, 2024 02:14
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-166-reduce-workflow-engine-test-time branch from 1eaf4f9 to 230a5d0 Compare April 25, 2024 02:15
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-166-reduce-workflow-engine-test-time branch from 230a5d0 to 6828d8a Compare April 25, 2024 02:16
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-166-reduce-workflow-engine-test-time branch from 6828d8a to eaf94a4 Compare April 25, 2024 02:19
@HenryNguyen5 HenryNguyen5 marked this pull request as ready for review April 25, 2024 02:22
@HenryNguyen5 HenryNguyen5 requested a review from a team as a code owner April 25, 2024 02:22
@HenryNguyen5 HenryNguyen5 changed the title Improve workflow engine test times [Keystone] Improve workflow engine test times Apr 25, 2024
@HenryNguyen5 HenryNguyen5 requested a review from DeividasK April 25, 2024 03:18
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-166-reduce-workflow-engine-test-time branch from eaf94a4 to b65d6ec Compare April 25, 2024 23:32
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-166-reduce-workflow-engine-test-time branch from cbfe586 to 133e961 Compare April 25, 2024 23:51
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-166-reduce-workflow-engine-test-time branch from 133e961 to ba7c094 Compare April 26, 2024 04:29
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-166-reduce-workflow-engine-test-time branch from ba7c094 to 570f166 Compare April 26, 2024 04:31
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-166-reduce-workflow-engine-test-time branch from 570f166 to d71d094 Compare April 26, 2024 04:46
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Apr 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 29, 2024
@HenryNguyen5 HenryNguyen5 added this pull request to the merge queue Apr 29, 2024
Merged via the queue into develop with commit e482c79 Apr 30, 2024
105 checks passed
@HenryNguyen5 HenryNguyen5 deleted the chore/KS-166-reduce-workflow-engine-test-time branch April 30, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants